Conversation
|
These are the same failures seen in: |
|
For the deprecation warning, we could add an exclusion to the pytest configuration, I believe? A |
|
Yes, the upstreams already know about it, let's update filterwarnings =
error
ignore:'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
ignore:'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction.. instead:DeprecationWarning:aiohttp
ignore:'asyncio.set_event_loop' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
ignore:'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio |
|
Thanks for the ping, CLA Bot the Second.
Updated and CI is now green. |
|
Hmm, the failure were the same as: but that was closed in favor of: which had no failures. Around the same time, @dependabot also created a PR for this repo: After merging it, I updated this branch hoping that the failures would disappear, as it happened for bedevere, but they didn't. Upon further investigation, I noticed that some packages haven't been updated: Lines 1 to 5 in e10ab1b python/bedevere#662 updated The changelog for the releases (3.11.14/15) don't mention anything about the deprecation, but there is now a new release (3.11.16) that includes:
We should be able to remove the filters and update I was also wondering why the updated wasn't included in #418. Turns out that on April 1st:
This explains why 3.11.15 wasn't included in #418, but 3.11.14 was released 3 weeks ago and should have been included. Maybe @dependabot wanted to prank us creating PRs at 4:04AM with a dependency not found on April 1st? |
|
The following issue is still not fixed and causes a few deprecation warnings: All the other issues seem to be fixed. I think we can wait a bit more to see if this last issue gets fixed, and merge the PR once all the deprecation warnings are gone. Note that there are also a couple of warnings that don't cause failures:
These are not blockers for this PR. |
The deprecation warnings have been addressed as part of pytest-asyncio v1.0.0 and should no longer bubble up to your test code. |
|
Thanks all! |
|
Thanks @seifertm for fixing the issue and releasing v1.0.0! Tests are now passing on all branches, so this PR is ready to be merged. |
Add 3.14, just like 3.13 was added in: